-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ref: Simplify expressions in physical plan #782
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change expressions to always produce the result of the expression. This simplifies evaluation, without affecting the expressiviness: 1. We can now produce a primitive result (such as a boolean or integer) if that is the type of the final expression. 2. We can still produce records by adding a `record` expression to the end (which is the standard way of creating intermediate records). 3. We can still reference parts of a record input using `FieldRef`. This eliminates the weird "some expressions are marked as output" pattern. It also means that we can operate on `ArrayRef` generally and use `DataType` as the type, instead of sometimes using `RecordBatch` and `SchemaRef`. Other smaller changes in this PR: - Move the `Expressions` out of the `StepKind`. This allows the `StepKind` to serve as an identifier of the step, regardless of the expressions it computes, simplifying some of the de-duplication work in the logical-to-physical compilation. - Rename the `column` expression to `input`, since it accesses the input data to the expression evaluation. - Addition of a method to "intern" expression names, replacing a `&str` with `&'static str` for expression operators available in the binary.
cla-bot
bot
added
the
cla-signed
Set when all authors of a PR have signed our CLA
label
Sep 29, 2023
jordanrfrazier
approved these changes
Oct 2, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, good simplification of expressions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change expressions to always produce the result of the expression. This simplifies evaluation, without affecting the expressiviness:
record
expression to the end (which is the standard way of creating intermediate records).FieldRef
.This eliminates the weird "some expressions are marked as output" pattern. It also means that we can operate on
ArrayRef
generally and useDataType
as the type, instead of sometimes usingRecordBatch
andSchemaRef
.Other smaller changes in this PR:
Expressions
out of theStepKind
. This allows theStepKind
to serve as an identifier of the step, regardless of the expressions it computes, simplifying some of the de-duplication work in the logical-to-physical compilation.column
expression toinput
, since it accesses the input data to the expression evaluation.&str
with&'static str
for expression operators available in the binary.